×
Login Register an account
Top Submissions Explore Upgoat Search Random Subverse Random Post Colorize! Site Rules Donate
4

poo in the loo strikes again!

submitted by heytheremyfriends to Rants 1.6 yearsOct 13, 2023 11:33:12 ago (+4/-0)     (Rants)

Some backstory, this asshole is a software architect who got "dumped" into our team after the prior team rage quite and informally got rid of him. We can't really fire him since firing is not something anyone on our team can do, best we can do is shuffle him around. He came to me today with a small issue. His data grid was reflecting a to string instead of a property. It stumped him alright. He had no idea what to do. I pulled his code and fixed his riddling issue in no time. His properties were being intentionally set to private and should have been public. In the absence of a valid property, the datagrid reflected a stringify call to the object. Hence the error he was seeing. It took me a whomping 5 seconds to figure this out.

I did some digging on the rest of the code he wrote, and I nearly had a heart attack. He started with multiple lists being fed to the data grid from an API (this was written by someone competent so no complaints there). This complete fucking idiot was re duplicating 4 lists into local variables. Upon figuring out why someone would do something so stupid, it had to do with a complete misunderstanding of the datagrid. The datagrid gets fed a datasource, and can be constructed from anything. This moron was recreating a custom object for the data source, doing a bunch of move constructors into the data grid to recreate a new data source. Now the code has 10 data sources: the 4 API ones, 4 new clones, one new clone of the 4 clones, and a property that is a clone of the clone of the 4 clones.

On a data grid that should hold 10,000 records, this guy is creating 60,000 EXTRA, completely useless memory records to load the grid!!! Needless to say, the performance was complete dog shit and Whitey is gonna have go to in and fix this fucking mess, as is tradition


8 comments block

bobdole9 0 points 1.6 years ago

I pretended I could understand backend development...now I just play with websites.

Dude probably has zero idea he can just use the original object.

What language do you code for? PHP is awful, but its hard to be retarded when writing in .NET